I agree on everything you said, we don't know how the writers are thinking. I mean it's bad enough they ruined Storm (Honestly I hate the mohowk cuz it always changes her personality in my opinion)
Couple things I'll point out here:
The mohawk predates this current run.
Storm's attitude has always been a fierce one. She's cool like a sunny day in early May in one second and then in a flash of lightning, she's an energized tempest of anger and hostility. Her character is all over the place emotionally.
She's one of Xavier's key students for a multitude of reasons besides being intelligent. I assume as a Storm fan you know her origins?
For me, those origins make her one of the most incredible of the batch. They're all social outcasts, but she was a different story... A little closer to Colossus' really, but still very different.
Most of the mutants from the Uncanny Giant Size issue who then became the 2nd Generation, all started as being sort of convicts of the human kind. They were chased out (Kurt), treated as tools or weapons (Logan, arguably Colossus who had to use his mutant strength to keep his family's poor Russian farm running/save his sister), and then Banshee and Thunderbird who just were social outcasts,... I believe. (Should re-read that). So all together, very negative experiences.
THEN THERE'S STORM. She starts as a street-thief/homeless young girl and became a "goddess" and a "windrider" long before Xavier & his crew came to gather her for their school. She isn't seen as a just
a freak, she is also seen as a savior, a miracle, a god, and a friend. That is huge
in comparison to the others who all come from a place deeply seeded in hate. It wasn't that Storm wasn't subjected tot hat hardly. Ororo saw all sorts of hatred and prejudice. But...
With Xavier's help she learned of injustices and how to combat them. There were more than those that take place in the continent of Africa, but being her home is located there she takes a personal offense whenever any sort of injustice, human or mutant, takes place there.
And when she gets dark, she gets dark. I forget what it was that caused her to have the change of design originally, but it was along the same lines of what put her in Uncanny X-Force
most recently with Psylocke, Puck, & the others. In truth, she couldn't take it anymore. She has a mean streak, for sure, and in her character is an unquenched fear of those who are afraid of her, and a hostility to them as well. She has usually been good at keeping her shit together, but the mohawk for me is a sign that she's sort of trying to become her own person.
Greg Pak is currently running her solo (I'm assuming you read it?) and he's done a tremendous job capturing the aspect of her personality that is confused between a person meant to teach peace, defense, and balance when she grew up in, and is surrounded by, so much death and hatred.
So it makes sense she's with Logan now.
The two always had a ... thing
until Jean came back around, and then that sort of became Storm/Kurt's thing
until Raachel came around (damn Greys).
Logan IS a killer, and you can use the term WAS if you are a current Logan fan and feel like he's trying to curb that (I certainly don't), but he IS an educator now. He was headmaster (still is?) gave that position to Storm as well, and the two of them, being two of the oldest members besides Bobby & Hank, are the most appropriate to teach the young mutants the balance of the world.
Storm is especially perfect for Logan right now because he is dying. And he's kidding himself if he didn't think he was going to die soon anyways with his healing factor out. Storm, who has gotten particularly protective of him, is in denial of this too, but they both know what drove them together.
Her shot to finally be with someone who isn't just sweet, kind, flattering, and overtly-majestic (T'Challa) ... and a bit of a know-it-all, and an opportunity to be with someone a little more humble (despite his cathphrase being "I'm the best at what I do, bub"). She gets a great relationship out of this because Logan will never let anything happen to her, and I feel like T'Challa was too busy being an avenger and though the two were "cute" married, it didn't make sense why they didn't revisit them as a couple more often. (Though the "Black Panther" run with Storm was cool).
Logan gets to be with a friend. All the people he's been with, this is someone who won't
betray him and who I genuinely believe would want to be there to hold his hand on his way out.
The three of them, Kurt, Logan, and Storm... and you know what Pietor too, are all a very tight group of friends and though 4 sounds like a lot, they are the only remaining members of the X-Team they joined (and I say that knowing they consider themselves true X-Men and Scott to be a cheater-cheater-booger-eater-had-a-girl-and-wouldn't-meet-her-not-at-the-park-or-at-the-mall-he-wouldn't-answer-if-she'd-call). So...
That all said... Greg Pak's series really takes STORM out of her element and creates a book that I think is really about her as a freedomfighter, not as an X-man, and that I appreciate more than a team book featuring the character.
If she broke off from the X-Men completely after Logan's death, you wouldn't see me shed a tear. In fact, that might be the only way she finds her way back to T'Challa, to be honest. Not that she has to!